Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image garbage collections #609

Merged
merged 4 commits into from
Jul 27, 2024

Conversation

FrankYang0529
Copy link
Member

Copy link

github-actions bot commented Jul 16, 2024

Name Link
🔨 Latest commit bc36860
😎 Deploy Preview https://66a31ed50819900f780ccc4d--harvester-preview.netlify.app

docs/upgrade/troubleshooting.md Outdated Show resolved Hide resolved
docs/upgrade/troubleshooting.md Outdated Show resolved Hide resolved
docs/upgrade/troubleshooting.md Outdated Show resolved Hide resolved
@albinsun
Copy link

albinsun commented Jul 16, 2024

By the way, perhaps we can leverage imageMinimumGCAge to improve the cleanup process later.
Ref. https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/#kubelet-config-k8s-io-v1beta1-KubeletConfiguration

@FrankYang0529
Copy link
Member Author

Hi @albinsun, I addressed all comments. Thanks.

Copy link

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

docs/upgrade/troubleshooting.md Outdated Show resolved Hide resolved
docs/upgrade/troubleshooting.md Outdated Show resolved Hide resolved
docs/upgrade/troubleshooting.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@FrankYang0529 FrankYang0529 merged commit ebb638d into harvester:main Jul 27, 2024
2 checks passed
@FrankYang0529 FrankYang0529 deleted the HARV-6155 branch July 27, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants