Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add live migration limitations #614

Merged
merged 6 commits into from
Aug 7, 2024
Merged

feat: add live migration limitations #614

merged 6 commits into from
Aug 7, 2024

Conversation

Yu-Jack
Copy link
Collaborator

@Yu-Jack Yu-Jack commented Jul 19, 2024 •
edited
Loading

@Yu-Jack Yu-Jack self-assigned this Jul 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Name Link
🔨 Latest commit 23e5f23
😎 Deploy Preview https://66aa012a45861198cb4f52f3--harvester-preview.netlify.app

@bk201 bk201 mentioned this pull request Jul 23, 2024
Closed
ibrokethecloud
ibrokethecloud reviewed Jul 25, 2024
View reviewed changes
docs/vm/live-migration.md Outdated

With `host-model`, it only allows the live migration process to migrate the VM to a node with same CPU model. For example, if the original CPU model is `XYZ`, it can migrate VM to another node with `XZY` CPU model. However, sometimes VM does not require a specified CPU model. In such case, we need to shut down the VM, assign a CPU model supported by all nodes, and then restart the VM.

Each node has primary CPU model labeled with `host-model-cpu.node.kubevirt.io` and mutliple supported CPU models which are labeled with `cpu-model.node.kubevirt.io`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably move this higher up in the section to explain how users can check host-model before they even launch a VM to help them decide if they wish to pin a different model?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibrokethecloud I've pushed new version.

This comment was marked as outdated.

Sign in to view

jillian-maroket

This comment was marked as outdated.

Sign in to view

jillian-maroket
jillian-maroket reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial review was based on text that no longer exists. I have added more suggestions.

docs/vm/live-migration.md Outdated Show resolved Hide resolved
docs/vm/live-migration.md Outdated Show resolved Hide resolved
Yu-Jack
Yu-Jack commented Jul 26, 2024
View reviewed changes
docs/vm/live-migration.md Outdated Show resolved Hide resolved
jillian-maroket
jillian-maroket reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the new sentence. I'll approve once this change is made. Thanks!

docs/vm/live-migration.md Outdated Show resolved Hide resolved
@jillian-maroket
Copy link
Contributor

jillian-maroket commented Jul 31, 2024 •
edited
Loading

@Yu-Jack Please add the following section to Hardware and Network Requirements (after the IMPORTANT note):

CPU Specifications

Live Migration functions correctly only if the CPUs of all physical servers in the Harvester cluster have the same specifications. This requirement applies to all operations that rely on Live Migration functionality, such as automatic VM migration when Maintenance Mode is enabled.

Newer CPUs (even those from the same vendor, generation, and family) can have varying capabilities that may be exposed to VM operating systems. To ensure VM stability, Live Migration checks if the CPU capabilities are consistent, and blocks migration attempts when the source and destination are incompatible.

When creating clusters, adding more hosts to a cluster, and replacing hosts, always use CPUs with the same specifications to prevent operational constraints.

bk201
bk201 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice enhancement to the migration limitation.

WebberHuang1118
WebberHuang1118 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Yu-Jack Yu-Jack merged commit 3b84d71 into harvester:main Aug 7, 2024
3 checks passed
@Yu-Jack Yu-Jack mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@WebberHuang1118 WebberHuang1118 WebberHuang1118 approved these changes

@ibrokethecloud ibrokethecloud ibrokethecloud approved these changes

@jillian-maroket jillian-maroket jillian-maroket approved these changes

Assignees

@Yu-Jack Yu-Jack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yu-Jack @jillian-maroket @bk201 @WebberHuang1118 @ibrokethecloud