feat: add manually install harvester cloud provider in rke2 #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <[email protected]>
|
Co-authored-by: Jillian <[email protected]>
Co-authored-by: Jillian <[email protected]>
Co-authored-by: Jillian <[email protected]>
|
Hi @jillian-maroket, thanks for review. I addressed all comments. 👍 |
TachunLin
approved these changes
Aug 26, 2024
docs/rancher/cloud-provider.md
Outdated
| permissions: '0644' | ||
| ``` | ||
|
|
||
| 1. On the Harvester UI, go to the **Cluster Configuration** screen and set the value of **Cloud Provider** to **External**. |
There was a problem hiding this comment.
LGTM.
Just a small suggestion whether we can use a more specific term for the Harvester UI, for example Rancher UI or RKE2 cluster creation page.
There was a problem hiding this comment.
Hi @TachunLin, yeah, it's clearer for users. Thanks.
There was a problem hiding this comment.
Thanks @FrankYang0529 for the update 👍
Signed-off-by: PoAn Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.