-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make Chosen more extendable #1647
Conversation
@@ -195,6 +190,14 @@ class Chosen extends AbstractChosen | |||
|
|||
@parsing = false | |||
|
|||
single_set_nosearch: -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should extract it in the Prototype version too, to stay consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! Would've come to that when testing extending the prototype version. For now will mark this WIP
👍 |
👍 This would be great to have official support for the new option code @koenpunt is working on without having to use a separate fork. |
A more modularized Chosen would let us build on things like AJAX searching or option adding without polluting the base functionality. I'm 100% in support of this general idea and this seems like a good first step. @koenpunt what else do you think needs to happen here before it's useful to you? |
👍 |
In an effort to clean up Chosen's PRs once and for all, @koenpunt and I just decided to close this one. Making Chosen more extendable would solve a lot of the issues people have with it, but this change is difficult to make without breaking most of the open PRs we're looking at. We're not saying no forever, but we are saying no for now. As Koen says, "for a better future". |
After keeping my PR for option adding (#166) up to date for over 2 years I got a suggestion from @mculp: koenpunt#38.
And by extracting more code into separate methods extending Chosen should become a breeze.