Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds options, removes static data #4

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ddrager
Copy link

@ddrager ddrager commented Mar 16, 2017

The biggest changes I made here:

  1. Removes data directories, since this is data imported from Kaggle
  2. Adds mandatory option -d to specify which data directory to use.
  3. Adds -y option for year, defaults to current year
  4. Updates deprecated sklearn function.

Thank you for this! New to ML, this was a neat learning experiment.

@harvitronix
Copy link
Owner

This is great, @ddrager. Thanks for the PR.

For the instructions and usage, I think you should add the -y ### as a suggestion so people know that's an arg without having to look at the code.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants