TYP: Fix new typechecking failures

Caused by upgrading pandas-stubs.
has2k1 · Nov 28, 2024 · 262b383 · 262b383
1 parent e5e028b
commit 262b383
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/plotnine/_utils/__init__.py b/plotnine/_utils/__init__.py
@@ -985,7 +985,7 @@ def cross_join(df1: pd.DataFrame, df2: pd.DataFrame) -> pd.DataFrame:
     if len(df2) == 0:
         return df1
 
-    return df1.join(df2, how="cross")  # type: ignore
+    return df1.join(df2, how="cross")
 
 
 def to_inches(value: float, units: str) -> float:

diff --git a/plotnine/geoms/geom_ribbon.py b/plotnine/geoms/geom_ribbon.py
@@ -181,10 +181,18 @@ def _draw_outline(
 
         if outline_type in ("lower", "both"):
             geom_path.draw_group(
-                data.eval(f"y = {y}min"), panel_params, coord, ax, **params
+                data.assign(y=data[f"{y}min"]),
+                panel_params,
+                coord,
+                ax,
+                **params,
             )
 
         if outline_type in ("upper", "both"):
             geom_path.draw_group(
-                data.eval(f"y = {y}max"), panel_params, coord, ax, **params
+                data.assign(y=data[f"{y}max"]),
+                panel_params,
+                coord,
+                ax,
+                **params,
             )