Fix geom_ribbon upper outline

fixes #728
has2k1 · Jan 4, 2024 · ab5bda0 · ab5bda0
1 parent 3e1af2a
commit ab5bda0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/doc/changelog.qmd b/doc/changelog.qmd
@@ -66,6 +66,8 @@ title: Changelog
 - Fixed using legend when using an identity scale and reordering the
   breaks. ({{< issue 735 >}})
 
+- Fixed drawing the upper outline of `geom_ribbon`. ({{< issue 728 >}})
+
 ### Enhancements
 
 - All `__all__` variables are explicitly assigned to help static typecheckers

diff --git a/plotnine/geoms/geom_ribbon.py b/plotnine/geoms/geom_ribbon.py
@@ -172,8 +172,7 @@ def _draw_outline(
         if outline_type == "full":
             return
 
-        x = "x"
-        y = "y"
+        x, y = "x", "y"
         if isinstance(coord, coord_flip):
             x, y = y, x
             data[x], data[y] = data[y], data[x]
@@ -184,4 +183,6 @@ def _draw_outline(
             )
 
         if outline_type in ("upper", "both"):
-            geom_path.draw_group(data, panel_params, coord, ax, **params)
+            geom_path.draw_group(
+                data.eval(f"y = {y}max"), panel_params, coord, ax, **params
+            )