Update to support latest craco alpha #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasanayan - The version of craco you have listed in this plugin has webpack 4 as a dependency. Therefore container is undefined on webpack and it crashes when trying to build. @tomap's changes solve these issues by both upgrading the craco dependency and including webpack 5 as a bundled dependency. Please merge this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(webpack 5 & react-scripts 5 compatible)
You might not want to use my package-lock.json but releasing an alpha version matching the craco alpha version would be great :)
(I'm not 100% sure that adding webpack 5 as a dependency is necessary)