Unique coupon code in org and assignee email in item #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace
reviewed
Jul 17, 2019
| DiscountCoupon.code == field.data | ||
| ) | ||
| .notempty() | ||
| ): |
There was a problem hiding this comment.
I'm not sure I get the difference between these two queries. Explain it?
There was a problem hiding this comment.
Previously it was searching for other instances of the same code being used in the same discount policy. I changed it to look inside the same organization until we figure out how to do it within the same item collection. Right now there is no relationship between a discount policy and an item collection, and discount coupons are created within an organization, and not an item collection. Hence this.
jace
requested changes
Jul 21, 2019
jace
approved these changes
Jul 22, 2019
|
@qurbat this one is for you. |
…#296) * Move webpack config and package json to assets folder. Add Make file * remove manifest.json * node_modules is already ignored below * Add make to travis script file
…into fix-coupon-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has 2 fixes -
Explanation for change in how discounts are looked up: