-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flask-monitoringdashboard app #438
base: main
Are you sure you want to change the base?
Conversation
What is the performance impact of this extension? |
@jace it writes to a second db. I tried load testing locally using |
When does it write? In the same request response cycle, or in a background job? Writing to a second db will still freeze the request until the database finishes committing. |
@@ -25,3 +25,5 @@ hasjob/static/gen | |||
*.gz | |||
*.bz2 | |||
hasjob/assets/node_modules | |||
admindash-config.cfg | |||
flask_monitoringdashboard.db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use SQLite in production as there are multiple worker processes competing for control over this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default it uses sqlite and creates this file. I moved it to postgres.
@@ -25,3 +25,5 @@ hasjob/static/gen | |||
*.gz | |||
*.bz2 | |||
hasjob/assets/node_modules | |||
admindash-config.cfg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config should be stored in the instance
folder.
return 'anon' | ||
|
||
|
||
dashboard.config.get_group_by = get_user_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group by event session, not user.
|
Implemented flask-monitoringdashboard This app gives us some metrics about HTTP requests on the endpoints we choose. Couple of pros are -