-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imgee V2 #59
Merged
Imgee V2 #59
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
441629f
removed celery as dependency
7337d16
fixed - was missing folder name when downloading file
ba53794
handling multiple resize request for same file
412e44b
removed print statements
9a49863
if there is an error while processing a file, raise it
127da69
fixed comment
be447ac
removed all tests
3b54fbd
removed more unnecessary things
6cd46ce
removed unnecessary imports and minor cleanup
57a99f0
renamed async.py
643e476
Merge pull request #56 from hasgeek/celery-removal
shreyas-satish 9ab5a45
added label tests
d57fec0
separating label logic
e0f547f
fixed label tests
cb7b9bd
more cleanup, moved some views out of index.py
c6c4645
cleaned up label saving codes a little
b3ff9f4
added tests for upload and delete
c663086
updated status code for delete test
e4ae277
mixed couple of migrations and showing error
eb5cab0
Merge pull request #57 from hasgeek/new-tests
shreyas-satish b4a14c1
some more cleanups
6fabf71
Merge pull request #58 from hasgeek/new-tests
shreyas-satish fc28fea
using get_image_url to create image url
edc1bf9
not showing delete label button if not logged in
95c1615
importing only the needed forms
95adecf
added tests for resizing files and testing with multiple file types
4451fb0
comparing redirect location with generated thumbnail url
4635676
added redis to travis
838d1ec
fixed conflicts
418e080
Merge branch 'master' of github.com:hasgeek/imgee into imgee-v2
f112e6c
fixed fixtures file to use new init_app behavior
cc369e6
fixed conflict
380bb87
Function name fix, using uuid1mc, time format fix, TaskRegistry fix (…
f2c6fd6
fixed conflict
23007ec
lot of minor fixes
59bb581
using dotted relative import syntax everywhere, added tests for regis…
d31b027
cleaning up queries and imports
ff390de
cleanup of os.path and more comments on thumbnail
6731ef9
fixed typo
3dcb9e5
added buildspec.yml file for testing AWS CodeBuild
d2c1228
setting env varialbe manually for aws codebuild
88457f5
removed buildspec.yml file
102e603
showing loading spinner if file is still processing
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just call this function directly? Unless it's an inbuilt Jinja filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an inbuilt filter of jinja.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it needs a
binary
parameter too. https://github.com/pallets/jinja/blob/master/jinja2/filters.py#L459There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the binary format? By default it's
False
.