treasury smart contract + tests + mocks #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nadine.loepfe <[email protected]>
Signed-off-by: nadine.loepfe <[email protected]>
Signed-off-by: nadine.loepfe <[email protected]>
nadineloepfe
requested review from
rbarkerSL,
leninmehedy,
dchernokur and
m-swirldslabs
|
LGTM |
rbarkerSL
reviewed
Dec 17, 2024
Signed-off-by: nadine.loepfe <[email protected]>
I aligned it with main now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the treasury smart contract as well as 2 mocks for testing: erc20 (for usdc and erc3643) and the vault -> erc20 to mock erc3643 in testing should be sufficient because it extends erc20 functionality.
tests can only be run with Hardhat, don't forget to change in defaultNetwork.