simplified while loop

Signed-off-by: Atanas Atanasov <[email protected]>
hashgraph · Jan 30, 2025 · c4d7a5a · c4d7a5a
1 parent f9b8af4
commit c4d7a5a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/server/src/main/java/com/hedera/block/server/persistence/StreamPersistenceHandlerImpl.java b/server/src/main/java/com/hedera/block/server/persistence/StreamPersistenceHandlerImpl.java
@@ -205,8 +205,8 @@ private void handleBlockItems(final List<BlockItemUnparsed> blockItems)
         if (blockItems.getLast().hasBlockProof()) {
             currentWriterQueue = null;
         }
-        Future<BlockPersistenceResult> completionResult = completionService.poll();
-        while (Objects.nonNull(completionResult)) {
+        Future<BlockPersistenceResult> completionResult;
+        while ((completionResult = completionService.poll()) != null) {
             // @todo(545) is this loop really the best way to poll for the callables? Is there not a reactive way
             // to do this?
             try {
@@ -217,7 +217,6 @@ private void handleBlockItems(final List<BlockItemUnparsed> blockItems)
                     ackHandler.blockPersisted(blockNumber);
                     metricsService.get(BlocksPersisted).increment();
                     LOGGER.log(INFO, "Block [%s] persisted successfully.".formatted(blockNumber));
-                    completionResult = completionService.poll();
                 } else {
                     // @todo(545) should we handle non successful statuses directly here?
                 }