feat: implementation of transferTokens method (#200) (#211)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
hashgraph · Jan 22, 2025 · fd99e8a · fd99e8a
1 parent b92137f
commit fd99e8a
Show file tree

Hide file tree

Showing 3 changed files with 78 additions and 5 deletions.
diff --git a/contracts/HtsSystemContract.sol b/contracts/HtsSystemContract.sol
@@ -125,6 +125,21 @@ contract HtsSystemContract is IHederaTokenService, IERC20Events, IERC721Events {
         return dissociateTokens(account, tokens);
     }
 
+    function transferTokens(
+        address token,
+        address[] memory accountId,
+        int64[] memory amount
+    ) htsCall external returns (int64 responseCode) {
+        require(token != address(0), "transferTokens: invalid token");
+        require(accountId.length > 0, "transferTokens: missing recipients");
+        require(amount.length == accountId.length, "transferTokens: inconsistent input");
+        for (uint256 i = 0; i < accountId.length; i++) {
+            responseCode = transferToken(token, msg.sender, accountId[i], amount[i]);
+            require(responseCode == HederaResponseCodes.SUCCESS, "transferTokens: transfer failed");
+        }
+        responseCode = HederaResponseCodes.SUCCESS;
+    }
+
     function transferNFTs(
         address token,
         address[] memory sender,

diff --git a/contracts/IHederaTokenService.sol b/contracts/IHederaTokenService.sol
@@ -462,11 +462,11 @@ interface IHederaTokenService {
     /// @param token The ID of the token as a solidity address
     /// @param accountId account to do a transfer to/from
     /// @param amount The amount from the accountId at the same index
-    // function transferTokens(
-    //     address token,
-    //     address[] memory accountId,
-    //     int64[] memory amount
-    // ) external returns (int64 responseCode);
+    function transferTokens(
+        address token,
+        address[] memory accountId,
+        int64[] memory amount
+    ) external returns (int64 responseCode);
 
     /// Initiates a Non-Fungable Token Transfer
     /// @param token The ID of the token as a solidity address

diff --git a/test/HTS.t.sol b/test/HTS.t.sol
@@ -692,6 +692,64 @@ contract HTSTest is Test, TestSetup {
         assertEq(IERC721(CFNFTFF).ownerOf(serialId), to);
     }
 
+    function test_HTS_transferTokens_success() public {
+        // https://hashscan.io/testnet/account/0.0.1421
+        address owner = 0x4D1c823b5f15bE83FDf5adAF137c2a9e0E78fE15;
+        address[] memory to = new address[](1);
+        to[0] = makeAddr("bob");
+        uint256 amount = 4_000000;
+        int64[] memory amounts = new int64[](1);
+        amounts[0] = int64(int256(amount));
+
+        uint256 balanceOfOwner = IERC20(USDC).balanceOf(owner);
+        assertGt(balanceOfOwner, 0);
+        assertEq(IERC20(USDC).balanceOf(to[0]), 0);
+
+        vm.prank(owner);
+        vm.expectEmit(USDC);
+        emit IERC20Events.Transfer(owner, to[0], amount);
+        IHederaTokenService(HTS_ADDRESS).transferTokens(USDC, to, amounts);
+
+        assertEq(IERC20(USDC).balanceOf(owner), balanceOfOwner - amount);
+        assertEq(IERC20(USDC).balanceOf(to[0]), amount);
+    }
+
+    function test_HTS_transferTokens_invalid_token_address() public {
+        // https://hashscan.io/testnet/account/0.0.1421
+        address owner = 0x4D1c823b5f15bE83FDf5adAF137c2a9e0E78fE15;
+        address[] memory to = new address[](1);
+        to[0] = makeAddr("bob");
+        int64[] memory amounts = new int64[](1);
+        amounts[0] = 4_000000;
+        vm.prank(owner);
+        vm.expectRevert("transferTokens: invalid token");
+        IHederaTokenService(HTS_ADDRESS).transferTokens(address(0), to, amounts);
+    }
+
+    function test_HTS_transferTokens_inconsistent_input() public {
+        // https://hashscan.io/testnet/account/0.0.1421
+        address owner = 0x4D1c823b5f15bE83FDf5adAF137c2a9e0E78fE15;
+        address[] memory to = new address[](1);
+        to[0] = makeAddr("bob");
+        int64[] memory amounts = new int64[](2);
+        amounts[0] = 3_000000;
+        amounts[1] = 1_000000;
+        vm.prank(owner);
+        vm.expectRevert("transferTokens: inconsistent input");
+        IHederaTokenService(HTS_ADDRESS).transferTokens(USDC, to, amounts);
+    }
+
+    function test_HTS_transferTokens_missing_recipients() public {
+        // https://hashscan.io/testnet/account/0.0.1421
+        address owner = 0x4D1c823b5f15bE83FDf5adAF137c2a9e0E78fE15;
+        address[] memory to = new address[](0);
+        int64[] memory amounts = new int64[](1);
+        amounts[0] = 3_000000;
+        vm.prank(owner);
+        vm.expectRevert("transferTokens: missing recipients");
+        IHederaTokenService(HTS_ADDRESS).transferTokens(USDC, to, amounts);
+    }
+
     function test_HTS_transferNFTs_for_allowed_user() external {
         uint256[] memory serialId = new uint256[](1);
         serialId[0] = 1;