Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit correct Transfer and Approval events for ERC721 #194

Closed
acuarica opened this issue Jan 14, 2025 · 0 comments · Fixed by #215
Closed

Emit correct Transfer and Approval events for ERC721 #194

acuarica opened this issue Jan 14, 2025 · 0 comments · Fixed by #215
Assignees
@arianejasuwienas

Comments

@acuarica
Copy link
Contributor

The events declared for ERC721 in IERC721Events do not contain the Transfer and Approval methods. This is because the ERC721 implementation reuses the events from ERC20.

However, there is a slight difference. The uint256 argument is indexed for ERC721, but not for ERC20. This can lead to inconsistencies.

Use and emit the proper event definitions for the ERC721 implementation.
@acuarica acuarica added bug A error that causes the feature to behave differently than what was expected based on design docs and removed bug A error that causes the feature to behave differently than what was expected based on design docs labels Jan 14, 2025
@arianejasuwienas arianejasuwienas self-assigned this Jan 21, 2025
arianejasuwienas added a commit that referenced this issue Jan 22, 2025
@arianejasuwienas
fix: emit correct transfer and approval events (#194)
054a040 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@arianejasuwienas arianejasuwienas mentioned this issue Jan 22, 2025
Merged
2 tasks
arianejasuwienas added a commit that referenced this issue Jan 23, 2025
@arianejasuwienas
feat: keeping the initial selectors of the events (#194)
7798a0a 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 23, 2025
@arianejasuwienas
feat: reverting not needed changes (#194)
666f83b 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 23, 2025
@arianejasuwienas
test: checking for correct event in tests (#194)
f36c650 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 24, 2025
@arianejasuwienas
docs: better descriptions for nft events (#194)
4685c22 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 24, 2025
@arianejasuwienas
docs: wip (#194)
941418d 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 26, 2025
@arianejasuwienas
feat: making erc721 tests consistent with erc20 alternative (#194)
d298dab 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 28, 2025
@arianejasuwienas
feat: typescript check fix (#194)
352ecf0 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 28, 2025
@arianejasuwienas
test: hbar allowance on testent showcase (#194)
131f4e1 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 29, 2025
@arianejasuwienas
fix: emit correct transfer and approval events (#194) (#215)
e4a7e92 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Smart Contract Sprint Board Jan 29, 2025
arianejasuwienas added a commit that referenced this issue Jan 30, 2025
@arianejasuwienas
feat: making gettokeninfo a view function (#194)
70077a9 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arianejasuwienas arianejasuwienas

Labels
None yet
Projects
Smart Contract Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: emit correct transfer and approval events (#194) hashgraph/hedera-forking
2 participants
@acuarica @arianejasuwienas