fix: emit correct transfer and approval events (#194) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added
the
bug
acuarica
requested changes
Jan 22, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
acuarica
requested changes
Jan 23, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
andrewb1269hg
previously approved these changes
Jan 24, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
acuarica
previously approved these changes
Jan 27, 2025
…s-for-erc721 Signed-off-by: Mariusz Jasuwienas <[email protected]>
|
@acuarica I need your approval again (lost it by resolving the conficts between this branch and main in HTS.t.sol file). |
acuarica
approved these changes
Jan 28, 2025
arianejasuwienas
deleted the
194-emit-correct-transfer-and-approval-events-for-erc721
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Emit current transfer and approval events for ERC 721
Related issue(s):
Fixes #194
Notes for reviewer:
Checklist