Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Foundry] Fetch HIP-719 remote state for fungible tokens #143

Merged

Conversation

victor-yanev
Copy link
Contributor

Description:

Related issue(s):

Fixes #98

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@victor-yanev victor-yanev self-assigned this Nov 27, 2024
@victor-yanev victor-yanev added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Nov 27, 2024
@victor-yanev victor-yanev marked this pull request as ready for review November 27, 2024 16:06
@victor-yanev victor-yanev requested a review from a team as a code owner November 27, 2024 16:06
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

src/HtsSystemContractJson.sol Outdated Show resolved Hide resolved
src/HtsSystemContractJson.sol Outdated Show resolved Hide resolved
src/HtsSystemContractJson.sol Outdated Show resolved Hide resolved
src/HtsSystemContract.sol Outdated Show resolved Hide resolved
Signed-off-by: Victor Yanev <[email protected]>
Copy link

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some considerations

scripts/curl Show resolved Hide resolved
scripts/curl Show resolved Hide resolved
src/IMirrorNodeResponses.sol Show resolved Hide resolved
@hashgraph hashgraph deleted a comment Dec 3, 2024
@victor-yanev victor-yanev merged commit 71e0f30 into main Dec 3, 2024
8 checks passed
@victor-yanev victor-yanev deleted the 98-Fetch-HIP-719-remote-state-for-fungible-tokens branch December 3, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Foundry] Fetch HIP-719 remote state for fungible tokens
3 participants