feat: example usage in nft testing of our foundry library and hardhat plugin (#191) #209

arianejasuwienas · 2025-01-21T13:27:24Z

Description:

Basic usage of our Foundry library and Hardhat plugin has been added for NFTs. Users can now explore how our solution can be utilized in examples.
Adding support for royalties in both hardhat and foundry (it did not work).

Related issue(s):

#191

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

src/utils.js

arianejasuwienas · 2025-01-21T13:29:39Z

src/forwarder/mirror-node-client.js

-    async getNftByTokenIdAndSerial(tokenId, serialId, blockNumber) {
-        const timestamp = await this.getBlockQueryParam(blockNumber);
-        return this._get(`tokens/${tokenId}/nft/${serialId}?${timestamp}`);
+    async getNftByTokenIdAndSerial(tokenId, serialId, _blockNumber) {


Previous url was not correct.

It does not support the block numbers ;/ . That is why I'm not checking if the token belongs to any specific account in my tests - it can change the ownership in time.

arianejasuwienas · 2025-01-21T13:52:43Z

A lot of tests started to fail because of the:

     Error: the string "Warning: This is a nightly build of Foundry. It is recommended to use the latest stable version. Visit https://book.getfoundry.sh/announcements for more information. \nTo mute this warning set `FOUNDRY_DISABLE_NIGHTLY_WARNING` in your environment. \n\n" was thrown, throw an Error :)

Should we set this env variable inside the runner? Or update the foundry version used in the runner?

acuarica · 2025-01-21T23:27:41Z

Or update the foundry version used in the runner?

@arianejasuwienas

~~That would be better. However, we need to wait until the action we use support the stable version.~~

Should we set this env variable inside the runner?

Yes, as a workaround. Here's the PR to fix it #214.

… when testing nft (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

Signed-off-by: Mariusz Jasuwienas <[email protected]>

…HTSJson when the fallback_fee is null (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

Signed-off-by: Mariusz Jasuwienas <[email protected]>

src/slotmap.js

arianejasuwienas · 2025-01-22T14:31:15Z

contracts/HtsSystemContractJson.sol

@@ -201,6 +201,16 @@ contract HtsSystemContractJson is HtsSystemContract {
        return tokenInfo;
    }

+    // In order to properly decode the bytes returned by the parseJson into the Solidity Structure, the full,
+    // correct structure has to be provided in the input json, with all of the corresponding fields.
+    function _sanitizeFeesStructure(string memory json) private pure returns (string memory) {


fallback_fee is nullable in the json response from the mirror node, but abi decode requires it to be set in order to create proper structure. That is why I set the default value here when it is empty.

sure, but also there is a vm.parseJson(json, ".custom_fees.royalty_fees") that guards against null, right?

@acuarica Only when royalty_fees is null. For the barkaneer I had fallback_fee = null (substructure in the royalty fees object).

acuarica · 2025-01-22T22:09:28Z

examples/hardhat-hts/test/nft-ownerof.test.js

+        // https://hashscan.io/mainnet/token/0.0.4970613
+        const nft = await getContractAt('IERC721', '0x00000000000000000000000000000000004bd875');
+        expect(await nft['ownerOf'](1)).to.not.be.equal(
+            '0x0000000000000000000000000000000000000000'


can we compare against the current owner?

Yes, we can. But we get nft details for the latest block, so all it will take for our tests then is someone who owns this serial id = 1 to transfer it to someone else. (I'll apply your suggestion anyway :) ).

examples/hardhat-hts/test/nft.test.js

acuarica · 2025-01-22T22:11:49Z

examples/hardhat-hts/package-lock.json

-            "version": "0.0.1",
-            "resolved": "git+ssh://[email protected]/hashgraph/hedera-forking.git#daa80f304e396b35ab84135176ac6e48b8cab35f",
+            "version": "0.1.1",
+            "resolved": "git+ssh://[email protected]/hashgraph/hedera-forking.git#8533630770865fc5e3ae0341aee2b71b7d229350",


let's install from npm (instead of git) so it's closer to a what an actual user would use it.

Ok, I am getting it directly from npm, @acuarica . Unfortunately current version (0.1.1) won't work for this token anyway. Because it has royalty fees (and because of the incorrrect nft details path).

Perhaps we should split it in 2 PRs.

First: #218

And then, when the library is fixed we can update this package lock.

OR

We can merge this PR and create a new one soon after, with updated dependency (it's up to you). I like this idea even more, because then we would have the fix in the solidity smart contract too (for nullable substructure in royalty fees).

acuarica · 2025-01-22T22:14:02Z

contracts/HtsSystemContractJson.sol

@@ -201,6 +201,16 @@ contract HtsSystemContractJson is HtsSystemContract {
        return tokenInfo;
    }

+    // In order to properly decode the bytes returned by the parseJson into the Solidity Structure, the full,
+    // correct structure has to be provided in the input json, with all of the corresponding fields.
+    function _sanitizeFeesStructure(string memory json) private pure returns (string memory) {


sure, but also there is a vm.parseJson(json, ".custom_fees.royalty_fees") that guards against null, right?

…ls (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

Signed-off-by: Mariusz Jasuwienas <[email protected]>

acuarica · 2025-01-23T18:20:29Z

examples/hardhat-hts/package.json

@@ -9,7 +9,7 @@
    "author": "2024 Hedera Hashgraph, LLC",
    "license": "Apache-2.0",
    "devDependencies": {
-        "@hashgraph/system-contracts-forking": "hashgraph/hedera-forking",
+        "@hashgraph/system-contracts-forking": "^0.1.1",


as mentioned offline, given some fixes are part of this PR, for now we can continue using the package here from GitHub directly.

…sion is no stable (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

arianejasuwienas added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jan 21, 2025

arianejasuwienas self-assigned this Jan 21, 2025

arianejasuwienas requested a review from a team as a code owner January 21, 2025 13:27

arianejasuwienas requested a review from nadezhdapopovaa January 21, 2025 13:27

arianejasuwienas commented Jan 21, 2025

View reviewed changes

src/utils.js Outdated Show resolved Hide resolved

arianejasuwienas commented Jan 21, 2025

View reviewed changes

arianejasuwienas force-pushed the 191-nft-examples-hardhat-foundry branch from 1a56b4a to 5d8b6f7 Compare January 21, 2025 13:32

feat: nft - sample usage of hedera hts forking in hardhat and foundry…

01edc2b

… when testing nft (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

arianejasuwienas force-pushed the 191-nft-examples-hardhat-foundry branch from 5d8b6f7 to 01edc2b Compare January 22, 2025 10:41

arianejasuwienas requested a review from a team as a code owner January 22, 2025 10:41

fix: foundry warning (#191)

cf9da25

Signed-off-by: Mariusz Jasuwienas <[email protected]>

arianejasuwienas requested review from a team as code owners January 22, 2025 10:53

arianejasuwienas requested review from andrewb1269hg and nathanklick January 22, 2025 10:53

fix: foundry warning (#191)

63028de

Signed-off-by: Mariusz Jasuwienas <[email protected]>

arianejasuwienas marked this pull request as draft January 22, 2025 11:14

arianejasuwienas added 4 commits January 22, 2025 14:00

fix: using barkaneer as a sample token for tests, adding fix for the …

531d7bd

…HTSJson when the fallback_fee is null (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

fix: typo in the nft name (#191)

be1201d

Signed-off-by: Mariusz Jasuwienas <[email protected]>

fix: hardhat royalty fees fixed (#191)

a3aa7d2

Signed-off-by: Mariusz Jasuwienas <[email protected]>

fix: hardhat royalty fees fixed (#191)

ffe7144

Signed-off-by: Mariusz Jasuwienas <[email protected]>

arianejasuwienas marked this pull request as ready for review January 22, 2025 14:14

arianejasuwienas commented Jan 22, 2025

View reviewed changes

src/slotmap.js Show resolved Hide resolved

arianejasuwienas commented Jan 22, 2025

View reviewed changes

acuarica requested changes Jan 22, 2025

View reviewed changes

arianejasuwienas added 2 commits January 23, 2025 10:50

fix: applying mr suggestions comparing to equals rather than not equa…

768913d

…ls (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

chore: downloading hardhat plugin directly from npm (#191)

7c592e7

Signed-off-by: Mariusz Jasuwienas <[email protected]>

acuarica reviewed Jan 23, 2025

View reviewed changes

feat: resolving the package for example from the github until npm ver…

55f3b98

…sion is no stable (#191) Signed-off-by: Mariusz Jasuwienas <[email protected]>

arianejasuwienas requested a review from acuarica January 28, 2025 10:08

arianejasuwienas linked an issue Jan 28, 2025 that may be closed by this pull request

[Hardhat] Is is impossible to access the NFT data or royalty fees #217

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: example usage in nft testing of our foundry library and hardhat plugin (#191) #209

feat: example usage in nft testing of our foundry library and hardhat plugin (#191) #209

arianejasuwienas commented Jan 21, 2025 •

edited

Loading

arianejasuwienas Jan 21, 2025

arianejasuwienas commented Jan 21, 2025

acuarica commented Jan 21, 2025 •

edited

Loading

arianejasuwienas Jan 22, 2025

acuarica Jan 22, 2025

arianejasuwienas Jan 23, 2025

acuarica Jan 22, 2025

arianejasuwienas Jan 23, 2025

acuarica Jan 22, 2025

arianejasuwienas Jan 23, 2025

acuarica Jan 22, 2025

acuarica Jan 23, 2025

feat: example usage in nft testing of our foundry library and hardhat plugin (#191) #209

Are you sure you want to change the base?

feat: example usage in nft testing of our foundry library and hardhat plugin (#191) #209

Conversation

arianejasuwienas commented Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

arianejasuwienas commented Jan 21, 2025

acuarica commented Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arianejasuwienas commented Jan 21, 2025 •

edited

Loading

acuarica commented Jan 21, 2025 •

edited

Loading