Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: making gettokeninfo and its dependants a view function (#164) #224

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: making gettokeninfo and its dependants a view function (#164) #224

merged 1 commit into from
Feb 12, 2025

Conversation

arianejasuwienas
Copy link
Contributor

Description:

Makes HTS(address(0x167)).getTokenInfo and every other getters in the HTS become views.

Related issue(s):

Fixes #164

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@arianejasuwienas arianejasuwienas self-assigned this Jan 30, 2025
@arianejasuwienas arianejasuwienas added the Backlog Work that needs to be done sometime in the future. No milestone assigned or not yet available. label Jan 30, 2025
@arianejasuwienas arianejasuwienas force-pushed the 164-making-gettokeninfo-a-view-function branch from 70077a9 to 5a5f6f7 Compare January 30, 2025 10:54
@arianejasuwienas arianejasuwienas mentioned this pull request Jan 30, 2025
Closed
@arianejasuwienas arianejasuwienas changed the title feat: making gettokeninfo a view function (#164) feat: making gettokeninfo and its dependants a view function (#164) Jan 30, 2025
@acuarica acuarica added feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. and removed Backlog Work that needs to be done sometime in the future. No milestone assigned or not yet available. labels Feb 5, 2025
acuarica
acuarica requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move forward with this, let's fix warnings so we can merge it.

@acuarica acuarica marked this pull request as ready for review February 11, 2025 23:17
@acuarica acuarica requested a review from a team as a code owner February 11, 2025 23:17
@arianejasuwienas arianejasuwienas force-pushed the 164-making-gettokeninfo-a-view-function branch from 5b8578c to 5323a8f Compare February 12, 2025 11:27
@arianejasuwienas arianejasuwienas force-pushed the 164-making-gettokeninfo-a-view-function branch from 5ab698c to 94b6e2e Compare February 12, 2025 11:32
@arianejasuwienas
Copy link
Contributor Author

I rebased on the main branch to remove the warnings that would have appeared after the merge (due to the new method). The new method has been added there.

@arianejasuwienas arianejasuwienas merged commit 0fe9477 into main Feb 12, 2025
13 checks passed
@arianejasuwienas arianejasuwienas deleted the 164-making-gettokeninfo-a-view-function branch February 12, 2025 14:33
arianejasuwienas added a commit that referenced this pull request Feb 13, 2025
@arianejasuwienas
feat: making gettokeninfo and its dependants a view function (#164) (#…
122e436 
…224)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuarica acuarica acuarica approved these changes

Assignees

@arianejasuwienas arianejasuwienas

Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate whether to make getTokenInfo a view function
2 participants
@arianejasuwienas @acuarica