test: add unit tests for setLedgerId and fix expiry.second
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
acuarica
changed the title
setLedgerIdsetLedgerId and fix expiry.second
2 tasks
|
Looks great, thanks! |
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
pushed a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Luis Mastrangelo <[email protected]> Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Luis Mastrangelo <[email protected]> Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Luis Mastrangelo <[email protected]> Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Authored-by: Luis Mastrangelo <[email protected]> Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
added a commit
that referenced
this pull request
Feb 13, 2025
Authored-by: Luis Mastrangelo <[email protected]> Signed-off-by: Mariusz Jasuwienas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes unit tests for
setLedgerId. Additionally, it converts theexpiry.secondfield to seconds as this is what is expected from real HTS.Notes for reviewer:
@arianejasuwienas feel free to review and merge this PR into your own, and we should be good to go.