Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add hook to validate commit message #60

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore: add hook to validate commit message #60

merged 1 commit into from
Oct 7, 2024

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Oct 4, 2024 •
edited
Loading

Description:

This PR includes a commit hook to validate that the commit message is properly Signed-off-by.

Related issue(s):

Fixes #59.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica
Add hook to validate commit message
71f11db 
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica requested a review from a team as a code owner October 4, 2024 23:04
@acuarica acuarica linked an issue Oct 4, 2024 that may be closed by this pull request
Include git hook to validate commit message according to DCO #59
Closed
@acuarica acuarica changed the title Add hook to validate commit message chore: add hook to validate commit message Oct 5, 2024
arianejasuwienas
arianejasuwienas approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@arianejasuwienas arianejasuwienas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

natanasow
natanasow approved these changes Oct 7, 2024
View reviewed changes
Copy link

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuarica acuarica merged commit a568b2e into main Oct 7, 2024
9 checks passed
@acuarica acuarica deleted the 59-validate-signed-off-by branch October 7, 2024 13:53
@acuarica acuarica added the build Improve build, bundling or deployment process label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natanasow natanasow natanasow approved these changes

@arianejasuwienas arianejasuwienas arianejasuwienas approved these changes

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl david-bakin-sl was automatically assigned from hashgraph/hedera-smart-contracts

Assignees
No one assigned
Labels
build Improve build, bundling or deployment process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include git hook to validate commit message according to DCO
3 participants
@acuarica @natanasow @arianejasuwienas