Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused workflow files #145

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Removes unused workflow files to avoid confusion and reduce the potential attack surface.

Related Issues

@nathanklick nathanklick self-assigned this Mar 13, 2024
@nathanklick nathanklick requested a review from a team as a code owner March 13, 2024 18:16
@nathanklick nathanklick requested a review from acuarica March 13, 2024 18:16
@nathanklick nathanklick force-pushed the 00134-Cleanup-Unused-Workflows branch 2 times, most recently from 8c1f8e7 to f9e34c4 Compare March 16, 2024 23:39
@nathanklick nathanklick requested review from a team as code owners March 16, 2024 23:39
@nathanklick nathanklick requested a review from leninmehedy March 16, 2024 23:40
@nathanklick nathanklick force-pushed the 00134-Cleanup-Unused-Workflows branch from f9e34c4 to c4a8df7 Compare March 16, 2024 23:54
Copy link

Wallet Snap Unit Test Results

17 tests  ±0   17 ✅ ±0   50s ⏱️ +6s
 5 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c4a8df7. ± Comparison against base commit 8069475.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8069475) 66 43 65.15%
Head commit (c4a8df7) 66 (+0) 43 (+0) 65.15% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#145) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.79%. Comparing base (8069475) to head (c4a8df7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   61.79%   61.79%           
=======================================
  Files           6        6           
  Lines          89       89           
  Branches       11       11           
=======================================
  Hits           55       55           
+ Misses         34       33    -1     
- Partials        0        1    +1     

see 1 file with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@poi-son-ivy poi-son-ivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy one!

@nathanklick nathanklick merged commit 6a76859 into main Mar 17, 2024
9 checks passed
@nathanklick nathanklick deleted the 00134-Cleanup-Unused-Workflows branch March 17, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Github Action workflows
3 participants