Adapt storage capturing in OpcodeTracer for modularized execution #10357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10357 +/- ##
==========================================
Coverage 92.19% 92.19%
- Complexity 8038 8094 +56
==========================================
Files 984 988 +4
Lines 33548 33711 +163
Branches 4236 4264 +28
==========================================
+ Hits 30928 31079 +151
- Misses 1612 1618 +6
- Partials 1008 1014 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
requested review from
bilyana-gospodinova,
IvanKavaldzhiev,
filev94,
nickeynikolovv and
steven-sheehy
2 tasks
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/utils/EntityIdUtils.java
Outdated
Show resolved
Hide resolved
.../test/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracerTest.java
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
bilyana-gospodinova
previously approved these changes
Feb 11, 2025
Signed-off-by: Kristiyan Selveliev <[email protected]>
steven-sheehy
requested changes
Feb 11, 2025
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/utils/EntityIdUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
.../src/main/java/com/hedera/mirror/web3/evm/contracts/execution/traceability/OpcodeTracer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is a copy of #10307. (It was checkout from the pr fixing the states caching but it will be delayed due to needed upstream changes). So opening with main as base branch.
This PR fixes storage capturing in modularized execution.
Storage values are now read from mirror node writable states during execution.
Added a test who actually modifies storage of a contract and can verify execution.
This pr also fixes 4 failing test in
OpcodeServiceTests. NowOpcodeServiceTestfixes are completed.Changes:
OpcodeTracer- reads storage changes from writablestates - STORAGE_KEY for modularizedOpcodeTracerTest- adds codecov for new methodsOpcodeServiceTest- adds new test contract which modifies contract storage and verifies storage changesRelated issue(s):
Fixes #10259
Notes for reviewer:
This PR only captures properly storage changes from state after fixes from #10306 but since the mentioned PR might require changes upstream. In order not to slow down this PR it's opened from main. Tests will be passing but storage changes will be empty for now until resolution of the above PR where state will be properly populated.
Checklist