Refactor web3 test code #10358
Merged
Refactor web3 test code #10358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: filev94 <[email protected]>
filev94
force-pushed
the
10320-refactor-web3-test-code
branch
from
ef3d109 to
a64acef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10358 +/- ##
=========================================
Coverage 92.18% 92.19%
- Complexity 8094 8095 +1
=========================================
Files 988 988
Lines 33711 33712 +1
Branches 4264 4264
=========================================
+ Hits 31078 31081 +3
+ Misses 1618 1617 -1
+ Partials 1015 1014 -1 ☔ View full report in Codecov by Sentry. |
filev94
changed the title
kselveliev
previously approved these changes
Feb 11, 2025
|
Can increase pr description. |
hedera-mirror-web3/src/main/java/com/hedera/services/utils/EntityIdUtils.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileReadonlyTest.java
Show resolved
Hide resolved
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
...irror-web3/src/test/java/com/hedera/mirror/web3/service/AbstractContractCallServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
hedera-mirror-web3/src/main/java/com/hedera/services/utils/EntityIdUtils.java
Outdated
Show resolved
Hide resolved
...irror-web3/src/test/java/com/hedera/mirror/web3/service/AbstractContractCallServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
.../src/test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileReadonlyTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
|
kselveliev
approved these changes
Feb 13, 2025
steven-sheehy
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the persistFungibleToken() method and uses fungibleTokenPersist() from the parent class
Related issue(s):
Fixes #10320
Notes for reviewer:
Checklist