Updated the query to return all relevant transactions #9719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Sawarkar <[email protected]>
jnels124
requested changes
Nov 11, 2024
…evant-Transactions
Signed-off-by: Harsh Sawarkar <[email protected]>
jnels124
requested changes
Nov 12, 2024
| @@ -344,7 +345,8 @@ const getTransferDistinctTimestampsQuery = ( | |||
|
|
|||
| // the condition to exclude synthetic transactions attached to a user submitted transaction | |||
| const transactionByPayerExcludeSyntheticCondition = `${Transaction.getFullName(Transaction.NONCE)} = 0 or | |||
| ${Transaction.getFullName(Transaction.PARENT_CONSENSUS_TIMESTAMP)} is not null`; | |||
| ${Transaction.getFullName(Transaction.PARENT_CONSENSUS_TIMESTAMP)} is not null | |||
| or ${Transaction.getFullName(Transaction.TYPE)} in (${typesToInclude.map((type) => `'${type}'`).join(', ')})`; | |||
There was a problem hiding this comment.
Once other comments are addressed, .map can be removed. Also, we should only add condition if array is not empty.
There was a problem hiding this comment.
Should update the hedera-mirror-rest/__tests__/specs/transactions/account-id.json spec test to include these types of transactions.
| @@ -41,6 +41,10 @@ hedera: | |||
| username: metrics | |||
| uriPath: "/swagger" | |||
| ipMetrics: false | |||
| transactions: | |||
There was a problem hiding this comment.
This should be the protoId of these types. See TransactionType.java.
There was a problem hiding this comment.
Also, should move this config to be under the query config and change typesToInclude to precedingTransactionTypes and add config prop to configuration.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modified the query to return all relevant transaction
Related issue(s):
Fixes #9606
Notes for reviewer:
Checklist