Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retry to Acceptance Test Steps #9754

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jnels124
Copy link
Contributor

Description:

  • add retry to get around stale cache

Related issue(s):

Fixes #9751

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added bug Type: Something isn't working test Test infrastructure, automated tests required, etc regression labels Nov 13, 2024
@jnels124 jnels124 added this to the 0.119.0 milestone Nov 13, 2024
@jnels124 jnels124 self-assigned this Nov 13, 2024
@jnels124 jnels124 linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (35367e5) to head (d1bbff8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9754      +/-   ##
============================================
- Coverage     92.23%   92.23%   -0.01%     
  Complexity     7628     7628              
============================================
  Files           937      937              
  Lines         32117    32117              
  Branches       4071     4071              
============================================
- Hits          29623    29622       -1     
  Misses         1542     1542              
- Partials        952      953       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 13, 2024

@jnels124 jnels124 marked this pull request as ready for review November 13, 2024 19:53
@jnels124 jnels124 requested a review from a team as a code owner November 13, 2024 19:53
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 merged commit 0c38f14 into main Nov 13, 2024
34 checks passed
@jnels124 jnels124 deleted the 9751-acceptance-failure-in-integration branch November 13, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working regression test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance failure in integration
4 participants