Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pull protos from services #2043

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Oct 21, 2024

Description:

We need to migrate the protobuf definitions from the hedera-protobufs repository to pull from the hedera-services repository. This change is aimed at simplifying the development process and centralizing all Protobuf-related files directly within the hedera-services repo, ensuring they stay in sync with service code.

Related issue(s):

Fixes #2032

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the protobuf This feature is dependent on Hedera protobuf updates label Oct 21, 2024
@0xivanov 0xivanov self-assigned this Oct 21, 2024
@0xivanov 0xivanov requested a review from a team as a code owner October 21, 2024 13:51
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 824c16d into main Oct 23, 2024
11 checks passed
@0xivanov 0xivanov deleted the migrate-protobufs-to-pull-from-services-repo branch October 23, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf This feature is dependent on Hedera protobuf updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate protobuf definitions to pull from hedera-services repo
2 participants