chore: remove IllegalStateException when specific node id is not present in address book
#2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
0xivanov
changed the title
IllegalStateException from executableIllegalStateException when a NodeID is not present in address book
0xivanov
changed the title
IllegalStateException when a NodeID is not present in address bookIllegalStateException when specific node id is not present in address book
0xivanov
deleted the
2044-Some-node-account-IDs-did-not-map-to-valid-nodes-in-the-client's-network
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR ignores a node when the node is not present in the address book, instead of throwing an exception.
This helps with wallets not having to update the SDK every time the address book gets changed.
Related issue(s):
Fixes #2044
Notes for reviewer:
Checklist