-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump com.esaulpaugh:headlong from 12.1.0 to 12.3.3 in /sdk-dependency-versions #2059
chore(deps): bump com.esaulpaugh:headlong from 12.1.0 to 12.3.3 in /sdk-dependency-versions #2059
Conversation
Don't like that the build check fails with this version of headlong
@dependabot rebase |
a4672b4
to
f16360d
Compare
@dependabot rebase |
Bumps [com.esaulpaugh:headlong](https://github.com/esaulpaugh/headlong) from 12.1.0 to 12.3.3. - [Release notes](https://github.com/esaulpaugh/headlong/releases) - [Commits](esaulpaugh/headlong@v12.1.0...v12.3.3) --- updated-dependencies: - dependency-name: com.esaulpaugh:headlong dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
f16360d
to
d541ac0
Compare
@mishomihov00 want to look into why dependabot updates are breaking sdj java? |
@jjohannes Could you please take a look at why is this failing. The problem seems to be coming from this commit in the headlong repo, but I'm not sure how to fix it - esaulpaugh/headlong@0a63986#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R55 Tried a few different ways, but none of them are working. |
@mishomihov00 We have some dependencies that are not prepared to be used with the Java Module System (JPMS). headlong is/was one of them. In JPMS, each module has a unique With this update, headlong gets an official name, which is |
be80e30
to
00ecde5
Compare
Signed-off-by: Jendrik Johannes <[email protected]>
00ecde5
to
b865969
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2059 +/- ##
============================================
+ Coverage 82.20% 82.64% +0.44%
- Complexity 3588 3932 +344
============================================
Files 186 199 +13
Lines 11697 12729 +1032
Branches 1150 1253 +103
============================================
+ Hits 9615 10520 +905
- Misses 1604 1711 +107
- Partials 478 498 +20 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumps com.esaulpaugh:headlong from 12.1.0 to 12.3.3.
Release notes
Sourced from com.esaulpaugh:headlong's releases.
... (truncated)
Commits
69f964b
edits to commentsb1067d9
fix typo in documentatione12ceef
update workflow83ecb53
update workflow77f6277
update workflow1011f00
update workflow1e5bc50
update workflow5253961
update bouncycastle version78e475f
update workflow240d4d6
update workflowDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)