-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: consistent naming of Gradle configuration files / Gradle updates #12997
Conversation
Node: HAPI Test (Restart) Results2 tests 2 ✅ 7m 50s ⏱️ Results for commit c745d68. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 9m 15s ⏱️ Results for commit c745d68. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 20m 3s ⏱️ Results for commit c745d68. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 44m 57s ⏱️ Results for commit a4aef57. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 40m 6s ⏱️ Results for commit c745d68. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 20s ⏱️ Results for commit 54f4115. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 309 files ±0 2 309 suites ±0 3h 33m 6s ⏱️ + 1h 17m 20s Results for commit c745d68. ± Comparison against base commit 919b0d7. This pull request removes 4026 and adds 3790 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 13m 43s ⏱️ Results for commit 54f4115. ♻️ This comment has been updated with latest results. |
gradle/plugins/src/main/kotlin/com.hedera.gradlebuild.jpms-modules.gradle.kts
Outdated
Show resolved
Hide resolved
gradle/plugins/src/main/kotlin/com.hedera.gradlebuild.root.gradle.kts
Outdated
Show resolved
Hide resolved
gradle/plugins/src/main/kotlin/com.hedera.gradlebuild.jpms-modules.gradle.kts
Outdated
Show resolved
Hide resolved
a1f3c08
to
a0941f3
Compare
Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
@JeffreyDallas I cleaned up the PR and move some changes in documentation out of this one. Now there are no other approvals required. Could you re-approve? |
b2a6d3e
to
cc4e9b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12997 +/- ##
=============================================
- Coverage 67.23% 67.21% -0.03%
+ Complexity 36166 36160 -6
=============================================
Files 3700 3700
Lines 148961 148961
Branches 15501 15501
=============================================
- Hits 100155 100124 -31
- Misses 44483 44507 +24
- Partials 4323 4330 +7 ☔ View full report in Codecov by Sentry. |
dd76e88
to
54f4115
Compare
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
54f4115
to
a4aef57
Compare
wait until this is fixed: autonomousapps/dependency-analysis-gradle-plugin#1159 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
…es (#12997) Signed-off-by: Jendrik Johannes <[email protected]> Signed-off-by: Bilyana Gospodinova <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
hashgraph/hedera-services#12997 Signed-off-by: Jendrik Johannes <[email protected]>
Description:
Consistent names and locations for shared Gradle configuration (aka convention plugins). Changes:
build-source
tograldle/plugins
and merged to just one "plugins" project. This is what most projects do now. And I like that it keeps things you do not need to touch regularly hidden in the "gradle" folder (that we already have for the wrapper).com.hedera.gradle
namespace to indicate that these are "packages" for the "gradle build configurations" (and not production or test code). The idea is that the configuration (with the same naming) can be reused in other repos like pbj or hedera-sdk-java.com.hedera.gradle.platform
com.hedera.gradle.services
com.hedera.gradle.blocknode
-convention
suffix has been removed from all places where it was used. It was inconsistently used and does not add any value imo.com.hedera.gradle.jpms-modules
is now expressed in a more compact way using the new features for this of theorg.gradlex.jvm-dependency-conflict-resolution
plugin.Related issue(s):
#11568
Notes for reviewer:
Checklist