Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: generalize publishing setup #15471

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Sep 16, 2024

Description:

Do not have 'hedera-services' specifics in plugins so that they may be reused without modification in other repositories.

For this, we introduce two files in the folder for each "product"

  • developers.properties
  • description.txt (optional)

See changes in the PR for what these files contain.

Related issue(s):

#14255 / #15282

Notes for reviewer:

The information moved into the developers.properties files end up in the Metadata of the published Jars. E.g. here:
https://repo1.maven.org/maven2/com/hedera/hashgraph/hapi/0.53.5/hapi-0.53.5.pom

Please share if you have alternative/better suggestion for where we should maintain this information.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jjohannes jjohannes requested review from a team as code owners September 16, 2024 07:53
@jjohannes jjohannes requested a review from a team September 16, 2024 07:53
@jjohannes jjohannes requested review from a team as code owners September 16, 2024 07:53
@jjohannes jjohannes self-assigned this Sep 16, 2024
@jjohannes jjohannes added this to the v0.55 milestone Sep 16, 2024
@jjohannes jjohannes requested review from rbarkerSL and removed request for a team September 16, 2024 08:00
developers.properties Outdated Show resolved Hide resolved
Copy link

codacy-production bot commented Sep 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9780e5f) 109674 67724 61.75%
Head commit (9afd515) 109674 (+0) 67724 (+0) 61.75% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15471) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.23%. Comparing base (9780e5f) to head (9afd515).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15471   +/-   ##
==========================================
  Coverage      58.22%   58.23%           
- Complexity     21712    21714    +2     
==========================================
  Files           2801     2801           
  Lines         109857   109857           
  Branches       11229    11229           
==========================================
+ Hits           63965    63971    +6     
  Misses         42024    42024           
+ Partials        3868     3862    -6     

see 9 files with indirect coverage changes

Impacted file tree graph

developers.properties Outdated Show resolved Hide resolved
@jjohannes jjohannes force-pushed the 14255-generalize-maven-publish branch 2 times, most recently from 51745f7 to 342deef Compare September 22, 2024 16:38
lpetrovic05
lpetrovic05 previously approved these changes Sep 23, 2024
@jjohannes jjohannes modified the milestones: v0.55, v0.56 Oct 1, 2024
@jjohannes jjohannes force-pushed the 14255-generalize-maven-publish branch 2 times, most recently from 9488b14 to 367f029 Compare October 8, 2024 06:42
Do not have 'hedera-services' specifics in plugins so that they may
be reused without modification in other repositories.

For this, we introduce two files in the folder for each "product"
- developers.properties
- description.txt (optional)

See changes in the PR for what these files contain.

Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes force-pushed the 14255-generalize-maven-publish branch from 367f029 to 9afd515 Compare October 16, 2024 06:01
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! @jjohannes

Copy link
Member

@artemananiev artemananiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from platform-data perspective

@jjohannes jjohannes merged commit 73d8b92 into develop Oct 16, 2024
49 of 50 checks passed
@jjohannes jjohannes deleted the 14255-generalize-maven-publish branch October 16, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants