-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: generalize publishing setup #15471
Conversation
b4dac0c
to
c18df8e
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15471 +/- ##
==========================================
Coverage 58.22% 58.23%
- Complexity 21712 21714 +2
==========================================
Files 2801 2801
Lines 109857 109857
Branches 11229 11229
==========================================
+ Hits 63965 63971 +6
Misses 42024 42024
+ Partials 3868 3862 -6 |
51745f7
to
342deef
Compare
342deef
to
b1b8734
Compare
9488b14
to
367f029
Compare
Do not have 'hedera-services' specifics in plugins so that they may be reused without modification in other repositories. For this, we introduce two files in the folder for each "product" - developers.properties - description.txt (optional) See changes in the PR for what these files contain. Signed-off-by: Jendrik Johannes <[email protected]>
367f029
to
9afd515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! @jjohannes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from platform-data perspective
Description:
Do not have 'hedera-services' specifics in plugins so that they may be reused without modification in other repositories.
For this, we introduce two files in the folder for each "product"
See changes in the PR for what these files contain.
Related issue(s):
#14255 / #15282
Notes for reviewer:
The information moved into the
developers.properties
files end up in the Metadata of the published Jars. E.g. here:https://repo1.maven.org/maven2/com/hedera/hashgraph/hapi/0.53.5/hapi-0.53.5.pom
Please share if you have alternative/better suggestion for where we should maintain this information.
Checklist