Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Hip 991 submit message last tests #17185

Open
wants to merge 5 commits into
base: hip-991-submit-message
Choose a base branch
from

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Jan 2, 2025

Description:

Adding last missing tests for topic submit message.

Related issue(s):
#17086
Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ibankov ibankov added the Topic Fees HIP-991 implementation label Jan 2, 2025
@ibankov ibankov added this to the v0.59 milestone Jan 2, 2025
@ibankov ibankov self-assigned this Jan 2, 2025
@ibankov ibankov requested review from a team as code owners January 2, 2025 11:26
@ibankov ibankov requested a review from derektriley January 2, 2025 11:26
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e236632) 96158 65477 68.09%
Head commit (4f31f34) 96158 (+0) 65477 (+0) 68.09% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17185) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.32%. Comparing base (e236632) to head (4f31f34).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##             hip-991-submit-message   #17185      +/-   ##
============================================================
- Coverage                     64.32%   64.32%   -0.01%     
+ Complexity                    20983    20982       -1     
============================================================
  Files                          2557     2557              
  Lines                         96395    96395              
  Branches                      10098    10098              
============================================================
- Hits                          62003    62002       -1     
  Misses                        30726    30726              
- Partials                       3666     3667       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic Fees HIP-991 implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants