Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt StressTestingTool to work with Bytes representation of a transaction #17225

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

IvanKavaldzhiev
Copy link
Collaborator

Description:
This PR enhances StressTestingTool to work with Bytes form of a transaction and differentiate between application and system transaction.

Related issue(s):

Fixes #17083

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@IvanKavaldzhiev IvanKavaldzhiev added the Platform Tickets pertaining to the platform label Jan 6, 2025
@IvanKavaldzhiev IvanKavaldzhiev added this to the v0.59 milestone Jan 6, 2025
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Jan 6, 2025
@IvanKavaldzhiev IvanKavaldzhiev requested review from a team as code owners January 6, 2025 12:21
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Copy link

codacy-production bot commented Jan 6, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 91.43%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4f476f9) 97090 69249 71.32%
Head commit (726e5a4) 97122 (+32) 69304 (+55) 71.36% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17225) 35 32 91.43%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (4f476f9) to head (726e5a4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...om/swirlds/demo/stress/StressTestingToolState.java 93.93% 1 Missing and 1 partial ⚠️
...com/swirlds/demo/stress/StressTestingToolMain.java 0.00% 1 Missing ⚠️
...n/java/com/swirlds/platform/system/SwirldMain.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17225      +/-   ##
============================================
+ Coverage     67.48%   67.51%   +0.03%     
- Complexity    22228    22247      +19     
============================================
  Files          2600     2600              
  Lines         97327    97359      +32     
  Branches      10138    10145       +7     
============================================
+ Hits          65684    65736      +52     
+ Misses        27913    27890      -23     
- Partials       3730     3733       +3     
Files with missing lines Coverage Δ
...com/swirlds/demo/stress/StressTestingToolMain.java 0.00% <0.00%> (ø)
...n/java/com/swirlds/platform/system/SwirldMain.java 0.00% <0.00%> (ø)
...om/swirlds/demo/stress/StressTestingToolState.java 71.87% <93.93%> (+71.87%) ⬆️

... and 10 files with indirect coverage changes

Impacted file tree graph

andrewb1269hg
andrewb1269hg previously approved these changes Jan 6, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve file platform-sdk/platform-apps/tests/StressTestingTool/build.gradle.kts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt StressTestingTool to work with the Bytes format for system transactions
2 participants