Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERC Registry] Phase 3: Add Support for Scanning a Dynamic Number of Contracts #1131

Open
Tracked by #1107
quiet-node opened this issue Dec 24, 2024 · 0 comments · May be fixed by #1132
Open
Tracked by #1107

[ERC Registry] Phase 3: Add Support for Scanning a Dynamic Number of Contracts #1131

quiet-node opened this issue Dec 24, 2024 · 0 comments · May be fixed by #1132
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@quiet-node
Copy link
Member

quiet-node commented Dec 24, 2024

Description

The tool is currently designed to scan exactly 100 contracts in each run, with this limit hardcoded into the implementation. While this approach ensures consistent operation, it lacks flexibility for users who may want to scan a smaller, customized number of contracts.

For instance, users may want to scan only 1 or 2 contracts for quick tests or specific verifications rather than always processing 100 contracts. This lack of configurability can lead to unnecessary resource usage and longer execution times, especially when only a subset of the contracts is relevant to the user.

Solution

  • Add a new env config to hold the dynamic input
  • Enable scanning based on the dynamic input
@quiet-node quiet-node self-assigned this Dec 24, 2024
@quiet-node quiet-node added the enhancement New feature or request label Dec 24, 2024
@quiet-node quiet-node moved this from Backlog to Tasks In Progress in Smart Contract Sprint Board Dec 24, 2024
@quiet-node quiet-node added this to the 0.12.0 milestone Dec 24, 2024
@quiet-node quiet-node changed the title [ERC Registry] Phase 3: Enable manual contract addition based on user input. [ERC Registry] Phase 3: Add Support for Scanning a Dynamic Number of Contracts Dec 24, 2024
@quiet-node quiet-node moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Review
1 participant