feat: added support for ERC Registry tool to dynamically configure the number of contracts to scan per operation #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new configuration parameter,
SCAN_CONTRACT_LIMIT, to enhance the flexibility of the ERC Registry tool. Users can now dynamically configure the number of contracts scanned per operation, with a default value of 100 and a customizable range of 1 to 100.Additionally, this setting overrides the
limitparameter in thenextlink if one exists in storage or composed fromSTARTING_POINT. For example, if thenextlink is/api/v1/contracts?limit=100&order=asc&contract.id=gt:0.0.5294198andSCAN_CONTRACT_LIMITis set to 30, the link will be updated to/api/v1/contracts?limit=30&order=asc&contract.id=gt:0.0.5294198.Related issue(s):
Fixes #1131
Notes for reviewer:
Checklist