Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skipped tests for invalid token addresses and more than 10 airdrops in one token transfer list #1208

Open
Tracked by #1012
simzzz opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@simzzz
Copy link
Contributor

simzzz commented Jan 24, 2025

Currently some tests specifically for airdrop cases such as trying to claim/cancel an airdrop with an invalid token address, or when the token transfer list contains more than 10 tokens (which is the limit) are skipped. The reason for this is that they revert with INVALID_OPERATION_ID which is a generic exception and should be INVALID_TOKEN_ID for example. I originally thought this exception was the correct response, and since I can't catch it with getHTSResponseCode(), I just asserted for a reverted transaction. After more careful analysis this approach is not ideal and they should be changed to assert for the correct message once it's fixed on the services side.

@simzzz
Copy link
Contributor Author

simzzz commented Jan 24, 2025

Currently blocked by hashgraph/hedera-services#17534. Expected to be fixed in 0.60.0 or later version

@simzzz simzzz added the enhancement New feature or request label Jan 24, 2025
@simzzz simzzz moved this from Backlog to Blocked in Smart Contract Sprint Board Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Blocked
Development

No branches or pull requests

1 participant