Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas declaration should not be necessary on a contract deploy. #394

Closed
ebadiere opened this issue Sep 12, 2023 · 0 comments · Fixed by #695
Closed

Gas declaration should not be necessary on a contract deploy. #394

ebadiere opened this issue Sep 12, 2023 · 0 comments · Fixed by #695
Assignees
@quiet-node
Labels
bug Something isn't working

Comments

@ebadiere
Copy link
Contributor

Description

In the test ERC1155.js, removing the Constants.GAS_LIMIT_1_000_000 causes the test to fail. HIP 584 should have eased eth_estimateGas issues.

Steps to reproduce

  1. Remove the Constants.GAS_LIMIT_1_000_000 from the erc1155 contract deploy:
    before:
    erc1155 = await factory.deploy(uri, Constants.GAS_LIMIT_1_000_000)
    after
    erc1155 = await factory.deploy(uri)
  2. Run the test.

Additional context

No response

Hedera network

other

Version

v0.4.0

Operating system

macOS
@ebadiere ebadiere added the bug Something isn't working label Sep 12, 2023
@quiet-node quiet-node mentioned this issue Mar 5, 2024
Merged
2 tasks
@quiet-node quiet-node linked a pull request Mar 5, 2024 that will close this issue
fix: removed custom gas limit for ERC1155 deploy transaction (#394) #695
Merged
2 tasks
@quiet-node quiet-node self-assigned this Mar 6, 2024
quiet-node added a commit that referenced this issue Mar 6, 2024
@quiet-node
fix: removed custom gas limit for ERC1155 deploy transaction (#394) (#…
8974d28 
…695)

fix: removed custom gas limit for ERC1155 deploy transaction

Signed-off-by: Logan Nguyen <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quiet-node quiet-node

Labels
bug Something isn't working
Projects
Smart Contract Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removed custom gas limit for ERC1155 deploy transaction (#394) hashgraph/hedera-smart-contracts
2 participants
@ebadiere @quiet-node