Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed custom gas limit for ERC1155 deploy transaction (#394) #695

Conversation

quiet-node
Copy link
Member

Description:
Removed custom gas limit for ERC1155.

Related issue(s):

Fixes #394

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the bug Something isn't working label Mar 5, 2024
@quiet-node quiet-node self-assigned this Mar 5, 2024
@quiet-node quiet-node linked an issue Mar 5, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Mar 5, 2024

Test Results

242 tests  ±0   236 ✔️ +2   7m 55s ⏱️ +37s
  72 suites ±0       6 💤 ±0 
  14 files   ±0       0  - 2 

Results for commit 519f224. ± Comparison against base commit b7224a1.

@quiet-node quiet-node added the Tooling tooling label Mar 6, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@quiet-node quiet-node merged commit 8974d28 into main Mar 6, 2024
23 checks passed
@quiet-node quiet-node deleted the 394-gas-declaration-should-not-be-necessary-on-a-contract-deploy branch March 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Tooling tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gas declaration should not be necessary on a contract deploy.
2 participants