Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace release notes generator action with one maintained by stepsecurity #1027

Conversation

PavelSBorisov
Copy link
Member

Description:
The release-automation.yml workflow uses a release notes generator action that has an equivalent maintained by StepSecurity.
This PR replaces it with the StepSecurity variant.

Related issue(s):

Fixes #1018

Notes for reviewer:
N/A
Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@PavelSBorisov PavelSBorisov added the github_actions Pull requests that update GitHub Actions code label Nov 22, 2024
@PavelSBorisov PavelSBorisov self-assigned this Nov 22, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners November 22, 2024 13:51
@PavelSBorisov PavelSBorisov linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link

Test Results

 16 files  ± 0   83 suites  +1   12m 6s ⏱️ + 1m 17s
294 tests +15  288 ✅ +19  6 💤 ±0  0 ❌  - 4 
303 runs  +15  296 ✅ +19  7 💤 ±0  0 ❌  - 4 

Results for commit 621b6b4. ± Comparison against base commit e3c088b.

This pull request removes 1 and adds 16 tests. Note that renamed tests count towards both.
"before each" hook for "should be able to update fixed HTS fee and royalty fee in NFT" ‑ TokenManagmentContract Test Suite Update fees "before each" hook for "should be able to update fixed HTS fee and royalty fee in NFT"
should be able to update fixed HTS fee and royalty fee in NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee and royalty fee in NFT
should fail for updateFungibleTokenCustomFees when token is not associated to fee collector ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail for updateFungibleTokenCustomFees when token is not associated to fee collector
should fail for updateNonFungibleTokenCustomFees when token is not associated to fee collector ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail for updateNonFungibleTokenCustomFees when token is not associated to fee collector
should fail when fee has negative values for non fungible token ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when fee has negative values for non fungible token
should fail when fee has negative values ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when fee has negative values
should fail when fractional fee has denominator zero ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when fractional fee has denominator zero
should fail when the provided fee collector is invalid for NFT ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when the provided fee collector is invalid for NFT
should fail when the provided fee collector is invalid ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when the provided fee collector is invalid
should fail when the provided token id is invalid for NFT ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when the provided token id is invalid for NFT
should fail when the provided token id is invalid ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when the provided token id is invalid
…

@andrewb1269hg
Copy link

@PavelSBorisov you'll need to add a milestone to this PR then rebase the branch to fix the failure on the check.

@PavelSBorisov PavelSBorisov added this to the 0.11.0 milestone Nov 22, 2024
@PavelSBorisov PavelSBorisov merged commit f997912 into main Nov 25, 2024
34 of 35 checks passed
@PavelSBorisov PavelSBorisov deleted the 1018-update-release-notes-generator-action-to-step-security-version branch November 25, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release-notes-generator-action to step-security version
3 participants