Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ContractScanner service class to handle fetching contracts from mirror node #1044

Conversation

quiet-node
Copy link
Member

Description:
This PR introduces the fetchContracts() and fetchContractByteCode() methods to facilitate the retrieval of contracts from the mirror node. Additionally, it includes test coverage for the associated methods.

Related issue(s):

Fixes #1038

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Dec 3, 2024
@quiet-node quiet-node added this to the 0.11.0 milestone Dec 3, 2024
@quiet-node quiet-node self-assigned this Dec 3, 2024
@quiet-node quiet-node requested a review from a team as a code owner December 3, 2024 18:26
Copy link

github-actions bot commented Dec 3, 2024

Test Results

 16 files  ±0   83 suites  +2   12m 24s ⏱️ +21s
294 tests +5  288 ✅ + 9  6 💤 ±0  0 ❌  - 4 
303 runs  +6  296 ✅ +10  7 💤 ±0  0 ❌  - 4 

Results for commit a03d2ab. ± Comparison against base commit 9074fef.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
"before all" hook in "HIP583 Test Suite - Ethereum Transfer TX via system-contracts" ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts "before all" hook in "HIP583 Test Suite - Ethereum Transfer TX via system-contracts"
should test that can make fungible token transfer via system-contracts from hollow account to another ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Fungible Token Test should test that can make fungible token transfer via system-contracts from hollow account to another
should test that can make non-fungible token transfer via system-contracts from hollow account to another ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Non-Fungible Token Test should test that can make non-fungible token transfer via system-contracts from hollow account to another
should test that hollow account is created and the amount of fungible tokens is correctly transferred via system-contracts ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Fungible Token Test should test that hollow account is created and the amount of fungible tokens is correctly transferred via system-contracts
should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via system-contracts ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Non-Fungible Token Test should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via system-contracts
should test that second transfer fungible tokens via system-contracts to the hollow account is successful ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Fungible Token Test should test that second transfer fungible tokens via system-contracts to the hollow account is successful
should test that second transfer non-fungible tokens via system-contracts to the hollow account is successful ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Non-Fungible Token Test should test that second transfer non-fungible tokens via system-contracts to the hollow account is successful

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 1038-erc-registry-add-contractscanner-service-class-to-handle-fetching-contracts-from-mirror-node branch from 6307ae5 to b6fdafb Compare December 3, 2024 23:31
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>

fetchContracts

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node force-pushed the 1038-erc-registry-add-contractscanner-service-class-to-handle-fetching-contracts-from-mirror-node branch from b6fdafb to a03d2ab Compare December 4, 2024 00:12
Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 2 nits 🚀 .

@quiet-node
Copy link
Member Author

Will update and remove HEDERA_NETWORK env variable in future PR.

@quiet-node quiet-node merged commit 593cdad into main Dec 4, 2024
30 checks passed
@quiet-node quiet-node deleted the 1038-erc-registry-add-contractscanner-service-class-to-handle-fetching-contracts-from-mirror-node branch December 4, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERC Registry] Add ContractScanner service class to handle fetching contracts from mirror node
2 participants