-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ContractScanner service class to handle fetching contracts from mirror node #1044
Conversation
Test Results 16 files ±0 83 suites +2 12m 24s ⏱️ +21s Results for commit a03d2ab. ± Comparison against base commit 9074fef. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
6307ae5
to
b6fdafb
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]> fetchContracts Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
b6fdafb
to
a03d2ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 2 nits 🚀 .
tools/erc-repository-indexer/erc-contract-indexer/src/utils/constants.ts
Show resolved
Hide resolved
Will update and remove |
Description:
This PR introduces the
fetchContracts()
andfetchContractByteCode()
methods to facilitate the retrieval of contracts from the mirror node. Additionally, it includes test coverage for the associated methods.Related issue(s):
Fixes #1038
Notes for reviewer:
Checklist