feat: added RegistryGenerator service class to export ERC token contracts #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
force-pushed
the
1040-erc-registry-add-registrygenerator-service-class-to-handle-exporting-erc-contracts-into-json-files
branch
from
9064b8f to
a7a1606
Compare
natanasow
previously approved these changes
Dec 5, 2024
tools/erc-repository-indexer/erc-contract-indexer/src/services/registryGenerator.ts
Outdated
Show resolved
Hide resolved
tools/erc-repository-indexer/erc-contract-indexer/src/services/registryGenerator.ts
Outdated
Show resolved
Hide resolved
quiet-node
force-pushed
the
1040-erc-registry-add-registrygenerator-service-class-to-handle-exporting-erc-contracts-into-json-files
branch
from
a7a1606 to
e884eda
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
dismissed
natanasow’s stale review
The merge-base changed after approval.
quiet-node
force-pushed
the
1040-erc-registry-add-registrygenerator-service-class-to-handle-exporting-erc-contracts-into-json-files
branch
from
e884eda to
f69d641
Compare
Signed-off-by: Logan Nguyen <[email protected]>
natanasow
approved these changes
Dec 5, 2024
quiet-node
deleted the
1040-erc-registry-add-registrygenerator-service-class-to-handle-exporting-erc-contracts-into-json-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the RegistryGenerator service class, which exports ERC token contracts to JSON files and writes them to disk. Depending on the specified HEDERA_NETWORK value, the registry will create a dedicated folder for the JSON files.
Additionally, this PR removes the MIRROR_NODE_URL variable, as it is no longer needed.
Related issue(s):
Fixes #1040
Notes for reviewer:
This branch is based on PR #1048; therefore, the changes in PR #1048 are reflected in this PR.
Checklist