-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added getErcTokenInfo()
to retrieve detailed token information in the ERC Registry project.
#1064
Merged
quiet-node
merged 5 commits into
main
from
1059-erc-registry-phase-2-utilize-eth_call-for-enhanced-accuracy-and-to-retrieve-token-details
Dec 10, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
… contracts. Signed-off-by: Logan Nguyen <[email protected]>
Test Results 16 files ±0 83 suites ±0 12m 10s ⏱️ +39s Results for commit 94bee74. ± Comparison against base commit 78fb1ee. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
2 tasks
acuarica
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
tools/erc-repository-indexer/erc-contract-indexer/src/services/byteCodeAnalyzer.ts
Show resolved
Hide resolved
quiet-node
deleted the
1059-erc-registry-phase-2-utilize-eth_call-for-enhanced-accuracy-and-to-retrieve-token-details
branch
December 10, 2024 20:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ContractScanner
service class now includes a new method,contractCallRequest()
, which submits a contract call request to the mirror node targeting an ERC contract to fetch detailed standard token information such asname
,symbol
,decimals
, andtotalSupply
.ByteCodeAnalyzer
service leverages the newly addedContractScanner.contractCallRequest()
method to retrieve token information whenever a new ERC contract is detected.Below is an example of the output ERC object written to the registry:
Related issue(s):
Fixes #1059
Notes for reviewer:
Checklist