Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added acceptance test to validate the e2e flow of the ERC Registry project #1073

Conversation

quiet-node
Copy link
Member

Description:
This PR introduces a suite of acceptance tests to validate the end-to-end flow of the ERC registry project. These tests deploy a specified number of contracts, including ERC20, ERC721, and non-ERC contracts, to the target network defined in the environment. The suite then executes the ERC registry's main runner to index the entire target network, accurately detect ERC contracts, and correctly write them to the registry.

Related issue(s):

Fixes #1065

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Dec 11, 2024
@quiet-node quiet-node added this to the 0.11.0 milestone Dec 11, 2024
@quiet-node quiet-node self-assigned this Dec 11, 2024
@quiet-node quiet-node requested a review from a team as a code owner December 11, 2024 00:00
Copy link

Test Results

 16 files  ± 0   83 suites  +5   12m 15s ⏱️ + 6m 2s
294 tests +46  288 ✅ +51  6 💤 ±0  0 ❌  - 5 
303 runs  +29  296 ✅ +34  7 💤 ±0  0 ❌  - 5 

Results for commit ead0a12. ± Comparison against base commit b29a7dc.

This pull request removes 4 and adds 50 tests. Note that renamed tests count towards both.
"before all" hook for "should be able to change PAUSE key to contractId and pause the token with same contract" ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k "before all" hook for "should be able to change PAUSE key to contractId and pause the token with same contract"
"before all" hook in "Admin key set to contractId" ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId "before all" hook in "Admin key set to contractId"
"before all" hook in "HIP583 Test Suite - Ethereum Transfer TX via system-contracts" ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts "before all" hook in "HIP583 Test Suite - Ethereum Transfer TX via system-contracts"
"before each" hook for "should be able to update fixed fee in HTS token" ‑ TokenManagmentContract Test Suite Update fees "before each" hook for "should be able to update fixed fee in HTS token"
should be able to change ADMIN key to ECDSA_secp256k and perform admin action with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change ADMIN key to ECDSA_secp256k and perform admin action with same contract
should be able to change ADMIN key to contractId and perform admin action with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change ADMIN key to contractId and perform admin action with same contract
should be able to change FREEZE key to ECDSA_secp256k and freeze the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change FREEZE key to ECDSA_secp256k and freeze the token with the same account
should be able to change FREEZE key to contractId and freeze the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change FREEZE key to contractId and freeze the token with same contract
should be able to change PAUSE key to ECDSA_secp256k and pause the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change PAUSE key to ECDSA_secp256k and pause the token with the same account
should be able to change PAUSE key to contractId and pause the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change PAUSE key to contractId and pause the token with same contract
should be able to change WIPE key to ECDSA_secp256k and wipe the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change WIPE key to ECDSA_secp256k and wipe the token with the same account
should be able to change WIPE key to contractId and wipe the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change WIPE key to contractId and wipe the token with same contract
should be able to perform admin action with TokenManagementContract as ADMIN key ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to perform admin action with TokenManagementContract as ADMIN key
should be able to update fixed HTS fee and royalty fee in NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee and royalty fee in NFT
…

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, minor comments

@quiet-node quiet-node merged commit ddd373d into main Dec 12, 2024
30 checks passed
@quiet-node quiet-node deleted the 1065-erc-registry-phase-2-add-a-suite-of-acceptance-test-to-test-the-tool-against-localnode branch December 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERC Registry] Phase 2: Add a suite of acceptance test to test the tool against localnode
2 participants