-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added acceptance test to validate the e2e flow of the ERC Registry project #1073
Merged
quiet-node
merged 9 commits into
main
from
1065-erc-registry-phase-2-add-a-suite-of-acceptance-test-to-test-the-tool-against-localnode
Dec 12, 2024
Merged
test: added acceptance test to validate the e2e flow of the ERC Registry project #1073
quiet-node
merged 9 commits into
main
from
1065-erc-registry-phase-2-add-a-suite-of-acceptance-test-to-test-the-tool-against-localnode
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
…try project Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Test Results 16 files ± 0 83 suites +5 12m 15s ⏱️ + 6m 2s Results for commit ead0a12. ± Comparison against base commit b29a7dc. This pull request removes 4 and adds 50 tests. Note that renamed tests count towards both.
|
Nana-EC
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, minor comments
tools/erc-repository-indexer/erc-contract-indexer/tests/acceptance/acceptance.test.ts
Show resolved
Hide resolved
quiet-node
deleted the
1065-erc-registry-phase-2-add-a-suite-of-acceptance-test-to-test-the-tool-against-localnode
branch
December 12, 2024 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a suite of acceptance tests to validate the end-to-end flow of the ERC registry project. These tests deploy a specified number of contracts, including ERC20, ERC721, and non-ERC contracts, to the target network defined in the environment. The suite then executes the ERC registry's main runner to index the entire target network, accurately detect ERC contracts, and correctly write them to the registry.
Related issue(s):
Fixes #1065
Notes for reviewer:
Checklist