-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Resolve IHRC632 and IHRC904 definitions #1103
Conversation
Test Results 16 files + 1 83 suites +7 12m 4s ⏱️ +20s Results for commit eb73397. ± Comparison against base commit 364927f. This pull request removes 3 and adds 17 tests. Note that renamed tests count towards both.
This pull request removes 1 skipped test and adds 4 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
This reverts commit 54bb0e6. Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
b0f2894
to
ed1b66b
Compare
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, left some questions
contracts/system-contracts/hedera-account-service/IHRC906Facade.sol
Outdated
Show resolved
Hide resolved
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Description:
The repo had been missing specs for HIP 632 and 904 and 906.
Additionally, there wasn't a clear separation of facade contracts that EOAs can call directly from calls that a contract would use that would allow it to specify the entity being modified.
Each system contract HIP introduced new functions that apply to
IHederaTokenService
andIHederaAccountService
.For clearer specification an
IHRCXXXX
contract for a specific HIP XXXX will contain the functions introduced by that HIP that are callable by a contract only and utilize the system contract.Facade contracts will contain functions that are callable by contracts and EOAs directly.
In this case the address is the address of the entity and not the system contract.
The interfaces are introduced in this PR but eventually the goal is to let the System contract interfaces inherit the non facade interfaces that describe it e.g.
IHederaAccountService is IHRC632, IHRC906
IHRC906
and add commentshbarAllowance()
andhbarApprove()
getEvmAddressAlias()
,getHederaAccountNumAlias()
,isValidAlias()
,isAuthorizedRaw()
andisAuthorized()
toIHRC632.sol
isAuthorized()
toHederaAccountService.sol
IHTSStructs.sol
that contains all the structs used by the system contract and makes it easy for function reuseRelated issue(s):
Fixes #1083
Fixes #1101
Fixes #1102
Notes for reviewer:
Checklist