fix: replaced the SEVM library with a regex-based approach for the interface matching mechanism in ERC Registry project #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
konstantinabl
approved these changes
Dec 18, 2024
tools/erc-repository-indexer/erc-contract-indexer/tests/unit/services/byteCodeAnalyzer.test.ts
Show resolved
Hide resolved
quiet-node
deleted the
1114-erc-registry-phase-3-sevmcontractiserc-sometimes-fail-to-collect-legitimate-erc-20-or-erc-721-contracts-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR modified the bytecode analysis logic to utilize a regex-based approach in the ERC Registry project. This technique directly matches function and event signatures against the bytecode to ensure compliance with ERC-20 and ERC-721 standards. It replaces the previous implementation, which relied on the Contract.isErc() method from the SEVM library, offering greater simplicity by eliminating unnecessary overhead.
Related issue(s):
Fixes #1114
Notes for reviewer:
Checklist