Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented ERC-1155 detection support in the ERC Registry tool #1166

Merged

Conversation

quiet-node
Copy link
Member

Description:
This PR adds support for detecting ERC-1155 token contracts in the ERC Registry tool, along with unit and acceptance tests.

Related issue(s):

Fixes #1161

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Jan 13, 2025
@quiet-node quiet-node added this to the 0.12.0 milestone Jan 13, 2025
@quiet-node quiet-node self-assigned this Jan 13, 2025
@quiet-node quiet-node requested review from a team as code owners January 13, 2025 22:32
@quiet-node quiet-node linked an issue Jan 13, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 13, 2025

Test Results

 16 files  ± 0   83 suites  +7   12m 10s ⏱️ + 5m 43s
294 tests +55  288 ✅ +60  6 💤 ±0  0 ❌  - 5 
303 runs  +44  296 ✅ +49  7 💤 ±0  0 ❌  - 5 

Results for commit d2e8eb6. ± Comparison against base commit 7e56460.

This pull request removes 1 and adds 56 tests. Note that renamed tests count towards both.
"before all" hook for "should be able to delete token" ‑ TokenManagmentContract Test Suite "before all" hook for "should be able to delete token"
should be able to burn token ‑ TokenManagmentContract Test Suite should be able to burn token
should be able to change ADMIN key to ECDSA_secp256k and perform admin action with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change ADMIN key to ECDSA_secp256k and perform admin action with same contract
should be able to change ADMIN key to contractId and perform admin action with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change ADMIN key to contractId and perform admin action with same contract
should be able to change FREEZE key to ECDSA_secp256k and freeze the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change FREEZE key to ECDSA_secp256k and freeze the token with the same account
should be able to change FREEZE key to contractId and freeze the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change FREEZE key to contractId and freeze the token with same contract
should be able to change PAUSE key to ECDSA_secp256k and pause the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change PAUSE key to ECDSA_secp256k and pause the token with the same account
should be able to change PAUSE key to contractId and pause the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change PAUSE key to contractId and pause the token with same contract
should be able to change WIPE key to ECDSA_secp256k and wipe the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change WIPE key to ECDSA_secp256k and wipe the token with the same account
should be able to change WIPE key to contractId and wipe the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change WIPE key to contractId and wipe the token with same contract
should be able to delete token ‑ TokenManagmentContract Test Suite should be able to delete token
…

♻️ This comment has been updated with latest results.

acuarica
acuarica previously approved these changes Jan 13, 2025
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, left some questions if you feel like address them here

@quiet-node quiet-node merged commit 49e3ba1 into main Jan 14, 2025
34 checks passed
@quiet-node quiet-node deleted the 1161-erc-registry-phase-3-add-support-for-erc-1155-tokens branch January 14, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERC Registry] Phase 3: Add support for ERC-1155 tokens
2 participants