-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented ERC-1155 detection support in the ERC Registry tool #1166
feat: implemented ERC-1155 detection support in the ERC Registry tool #1166
Conversation
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Test Results 16 files ± 0 83 suites +7 12m 10s ⏱️ + 5m 43s Results for commit d2e8eb6. ± Comparison against base commit 7e56460. This pull request removes 1 and adds 56 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, left some questions if you feel like address them here
tools/erc-repository-indexer/erc-contract-indexer/src/utils/constants.ts
Show resolved
Hide resolved
tools/erc-repository-indexer/erc-contract-indexer/src/services/byteCodeAnalyzer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Description:
This PR adds support for detecting ERC-1155 token contracts in the ERC Registry tool, along with unit and acceptance tests.
Related issue(s):
Fixes #1161
Notes for reviewer:
Checklist