dapp-feat: ERC721 TokenPermission feature complere #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Test Results 17 files + 4 70 suites +8 9m 38s ⏱️ + 2m 3s For more details on these failures, see this check. Results for commit 1bb4b13. ± Comparison against base commit 75647d1. ♻️ This comment has been updated with latest results. |
Nana-EC
reviewed
Sep 19, 2023
| REJECT: { | ||
| // @notice 4001 error code is returned when a metamask wallet request is rejected by the user | ||
| // @notice See https://docs.metamask.io/wallet/reference/provider-api/#errors for more information on the error returned by Metamask. | ||
| message: '4001', |
There was a problem hiding this comment.
This should be code. See https://eips.ethereum.org/EIPS/eip-1193#provider-errors
Suggested change
| message: '4001', | |
| code: '4001', |
Signed-off-by: Logan Nguyen <[email protected]>
Nana-EC
approved these changes
Sep 19, 2023
| 'TRANSFER_EXCEEDS_BALANCE', | ||
| ]; | ||
|
|
||
| let errorDescription = HEDERA_COMMON_WALLET_REVERT_REASONS.DEFAULT.description; |
There was a problem hiding this comment.
Open a ticket to improve the handleAPIError() to map codes to error names.
This works for now but we can simplify later without special cases
quiet-node
deleted the
322-Add-contract-interacting-features-to-ERC721Contract
branch
mshakeg
pushed a commit
to mshakeg/hedera-smart-contracts
that referenced
this pull request
Oct 14, 2023
* dapp-feat: ERC721 Approve feature complete Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: added HEDERA_COMMON_WALLET_REVERT_REASONS constant object Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: replaced `message` with `code` Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s): #314
Fixes partial #322
UI Demo
Screen.Recording.2023-09-19.at.2.40.06.PM.mov
Notes for reviewer:
Checklist