Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp-feat: ERC721 Approval and TransferFrom feature complete #412

Merged

Conversation

quiet-node
Copy link
Member

Description:

  • ERC721 Approval feature complete
  • ERC721 TransferFrom feature complete

Related issue(s): #314

Fixes #322

** UI Demo **:

Screen.Recording.2023-09-19.at.7.34.18.PM.mov

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added enhancement New feature or request P2 Tooling tooling labels Sep 20, 2023
@quiet-node quiet-node added this to the 0.5.0 milestone Sep 20, 2023
@quiet-node quiet-node requested a review from a team as a code owner September 20, 2023 00:37
@quiet-node quiet-node self-assigned this Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Test Results

197 tests  ±0   191 ✔️ +2   7m 38s ⏱️ +3s
  62 suites ±0       6 💤 ±0 
  13 files   ±0       0  - 2 

Results for commit 215fce1. ± Comparison against base commit c96f7eb.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit cfc62c1 into main Sep 20, 2023
@quiet-node quiet-node deleted the 322-Add-contract-interacting-features-to-ERC721Contract branch September 20, 2023 02:36
mshakeg pushed a commit to mshakeg/hedera-smart-contracts that referenced this pull request Oct 14, 2023
…ph#412)

* dapp: ERC721 approval feature complete

Signed-off-by: Logan Nguyen <[email protected]>

* dapp: ERC721 TransferFroms feature complete

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-update: reused copyContentToClipboard()

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Tooling tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System Contract DApp] Add contract interacting features to ERC721Contract
2 participants