Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp-feat: ExchangeRate contract feature complete #418

Conversation

quiet-node
Copy link
Member

Description: This PR integrates ExchangeRate contract to the DApp

Related issue(s): #314

Fixes #396

** UI Demo **:

Screen.Recording.2023-09-21.at.11.51.11.AM.mov

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added enhancement New feature or request P2 Tooling tooling labels Sep 21, 2023
@quiet-node quiet-node added this to the 0.6.0 milestone Sep 21, 2023
@quiet-node quiet-node requested a review from a team as a code owner September 21, 2023 16:52
@quiet-node quiet-node self-assigned this Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Test Results

  15 files  +  1    66 suites  +2   8m 9s ⏱️ +36s
198 tests ±  0  191 ✔️ ±  0  6 💤 ±0  1 ±0 
208 runs  +10  201 ✔️ +10  6 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit c3c2a9a. ± Comparison against base commit 66ffc3a.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 396-(PR)-add-contract-interacting-features-to-ExchangeRate-contract branch from 8980fb3 to c3c2a9a Compare September 21, 2023 17:07
@quiet-node quiet-node merged commit 182bd23 into main Sep 22, 2023
@quiet-node quiet-node deleted the 396-(PR)-add-contract-interacting-features-to-ExchangeRate-contract branch September 22, 2023 01:53
mshakeg pushed a commit to mshakeg/hedera-smart-contracts that referenced this pull request Oct 14, 2023
* dapp-update: added ExchangeRatePrecompile to the main layout

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-feat: ExchangeRate feature complete

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Tooling tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System Contract DApp] Add contract interacting features to ExchangeRate contract
2 participants