-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dapp-refactor: reorganized shared items (#420) #422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
…ge and handleSanitizeFormInputs to main common shared method folder Signed-off-by: Logan Nguyen <[email protected]>
…o main methods folder Signed-off-by: Logan Nguyen <[email protected]>
…able() to its main shared folder Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
…ult to a shared type folder Signed-off-by: Logan Nguyen <[email protected]>
…lt with ISmartContractExecutionResult Signed-off-by: Logan Nguyen <[email protected]>
Test Results 22 files + 10 132 suites +95 15m 36s ⏱️ + 11m 9s For more details on these failures, see this check. Results for commit 11fac9e. ± Comparison against base commit 7968621. This pull request removes 2 and adds 89 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Nana-EC
approved these changes
Sep 23, 2023
mshakeg
pushed a commit
to mshakeg/hedera-smart-contracts
that referenced
this pull request
Oct 14, 2023
* dapp-refactor: moved /hooks folder to /src folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved handleRetrievingTransactionResultsFromLocalStorage and handleSanitizeFormInputs to main common shared method folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved erc/hooks to main hooks folder and erc/methods to main methods folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved prepareInfoValuesToShow() and TransactionResultTable() to its main shared folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: reorganized token-create-custom Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: reused copyContentToClipboard where needed Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: renamed handleRemoveRecord to handleRemoveMapRecord Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: renamed navsidebar Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: renamed interfaces and types Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved ITransactionResult && ISmartContractExecutionResult to a shared type folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: replaced IExchangeRateContractResult & IPRNGContractResult with ISmartContractExecutionResult Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: Mo Shaikjee <[email protected]>
ebadiere
pushed a commit
that referenced
this pull request
Oct 16, 2023
* dapp-refactor: moved /hooks folder to /src folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved handleRetrievingTransactionResultsFromLocalStorage and handleSanitizeFormInputs to main common shared method folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved erc/hooks to main hooks folder and erc/methods to main methods folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved prepareInfoValuesToShow() and TransactionResultTable() to its main shared folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: reorganized token-create-custom Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: reused copyContentToClipboard where needed Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: renamed handleRemoveRecord to handleRemoveMapRecord Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: renamed navsidebar Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: renamed interfaces and types Signed-off-by: Logan Nguyen <[email protected]> * dapp-refactor: moved ITransactionResult && ISmartContractExecutionResult to a shared type folder Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: replaced IExchangeRateContractResult & IPRNGContractResult with ISmartContractExecutionResult Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: ebadiere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR reorganized shared items within the DApp. More specifically:
moved /hooks folder from /src/components/contract-interactions/hts to /src
moved handleRetrievingTransactionResultsFromLocalStorage and handleSanitizeFormInputs custom hooks to main common shared method folder
added the method component files in /src/components/contract-interactions/hts/token-create-custom into their own folders
rework the
copyContentToClipboard()
where neededrenamed
handleRemoveRecord()
tohandleRemoveMapRecord()
renamed
leftSideBar
tonavSideBar
renamed interfaces and types (interface variables will have capital "I" at the beginning of the variable name and type variables will have capital "T" )
moved ITransactionResult && ISmartContractExecutionResult from /hts to /shared folder as it is used in other contracts rather than HTS'es
replaced IExchangeRateContractResult & IPRNGContractResult with ISmartContractExecutionResult
Related issue(s): #420
Fixes #420
Notes for reviewer:
Checklist